Added utility for loading tiered config from file system. #2
Conversation
eriq-augustine
left a comment
eriq-augustine
left a comment
There was a problem hiding this comment.
Be careful, there are several mistakes here that should not be.
We will also want to get the CLI with this.
We can break this up into two PRs:
- This one.
- One that adds the CLI.
eriq-augustine
left a comment
eriq-augustine
left a comment
There was a problem hiding this comment.
Tests are generally looking good.
eriq-augustine
left a comment
eriq-augustine
left a comment
There was a problem hiding this comment.
Looking pretty good.
We also need some text in the README covering how config works.
eriq-augustine
left a comment
eriq-augustine
left a comment
There was a problem hiding this comment.
Nice!
Looking pretty good.
eriq-augustine
left a comment
eriq-augustine
left a comment
There was a problem hiding this comment.
Documentation is looking much better.
I did not fully comment the new CLI option table,
since it needs some big changes.
eriq-augustine
left a comment
eriq-augustine
left a comment
There was a problem hiding this comment.
Documentation is getting pretty close.
eriq-augustine
left a comment
eriq-augustine
left a comment
There was a problem hiding this comment.
Getting better.
The source intros really help.
2 participants
Implemented a function that hierarchically loads configuration keys and values from JSON config files and CLI arguments, with an option to specify the target file name.