Skip to content

Conversation

@Asespinel
Copy link

@Asespinel Asespinel commented Mar 31, 2025

This PR adds messageIds in the instructor-toolbar in order to translate the labels and buttons correctly

  1. The instructor toolbar wasn't translating some messages correctly because they didn't have message IDs related with those lines
  2. This PR changes the hard coded messages of "View Course as" and "View course in" to format the translations into the HTML
  3. Adittionally we added the message IDs inside the translations fork here: eduNEXT/openedx-translations@06c2470

How to test

1.Create a tutor environment using version 18 (redwood)
2. Clone this repo and switch to this branch ase/fix/translation-messages
3. Go to your frontend-app-learning folder and install the dependencies using node 20 and running the command npm ci
4. Mount your frontend-app learning folder using tutor mounts add frontend-app-learning
5. Inside your frontend-app-learning modify the make command to grab the translations from our fork like this:

pull_translations:
	rm -rf src/i18n/messages
	mkdir src/i18n/messages
	cd src/i18n/messages \
	  && atlas pull --repository=eduNEXT/openedx-translations --revision=ednx-release/redwood.utec \
	           translations/frontend-platform/src/i18n/messages:frontend-platform \
	           translations/paragon/src/i18n/messages:paragon \
	           translations/frontend-component-header/src/i18n/messages:frontend-component-header \
	           translations/frontend-component-footer/src/i18n/messages:frontend-component-footer \
	           translations/frontend-lib-special-exams/src/i18n/messages:frontend-lib-special-exams \
	           translations/frontend-app-learning/src/i18n/messages:frontend-app-learning

	$(intl_imports) frontend-platform paragon frontend-component-header frontend-component-footer frontend-lib-special-exams frontend-app-learning
  1. Run the command above: make pull_translations
  2. The run tutor dev start
  3. Go to a course as a super user or staff member and you should be able to see the translations properly:
    image

Note to reviewers

The failing test has to do with codecov and we can ignore it for the moment

@Asespinel Asespinel requested a review from a team March 31, 2025 20:08
Copy link

@luisfelipec95 luisfelipec95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Asespinel Asespinel merged commit b396ffc into ednx-release/redwood.master Mar 31, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants