Ensure media is always visible and segments are followed dynamically. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This is a minor change that makes the player a little more user friendly.
First, the audio canvas is always sticky so it never is not visible no matter where the media is currently.
Second, it keeps segments and the media player always in sync so that as the current timestamp is updated the segment is always visible in the middle of the player.
Why am I adding this?
We've started to use this at my current shop to help in our process of reviewing vtt and transcript files. This adds functionality so I don't need to fork this or write my own thing from scratch.
If this is unwanted, no problem.