feat: implement AST evaluator with modifiers #6 #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the evaluator module that transforms parsed AST into roll results: **Core Implementation**: - Add RollResult and DieResult types in src/types.ts - Implement keep/drop modifiers (kh, kl, dh, dl) - Implement recursive AST evaluation with RNG injection - Track critical/fumble detection on individual dice - Ensure negative results are NOT clamped (1d4-5 = -4) **Parser Bug Fix**: - Fix modifier chaining: 4d6dl1kh3 now parses as (4d6dl1)kh3 - Change binding power from BP.MODIFIER to BP.DICE_LEFT - Prevents modifiers in count position while allowing computed counts - Satisfies PRD requirement for modifier chaining (line 478) **Tests**: - 37 evaluator unit tests (using MockRNG for determinism) - 5 parser tests for modifier chaining - Total: 186 tests passing (all green) **Documentation**: - Document evaluator limitation: sequential vs Roll20 behavior - Add gitignore entries for package-lock.json and pnpm-lock.yaml - Created follow-up issue #12 for evaluator refactor (Stage 2/3) **Validation**: All checks pass (typecheck, lint, format, build, test) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the evaluator module that transforms parsed AST into roll results:
Core Implementation:
Parser Bug Fix:
Tests:
Documentation:
Validation: All checks pass (typecheck, lint, format, build, test)
🤖 Generated with Claude Code