This repository was archived by the owner on Apr 9, 2020. It is now read-only.
Upgrade ReactNative to latest version#117
Open
ianfieldhouse wants to merge 9 commits intoedina:masterfrom
ianfieldhouse:upgrade-rn-work
Open
Upgrade ReactNative to latest version#117ianfieldhouse wants to merge 9 commits intoedina:masterfrom ianfieldhouse:upgrade-rn-work
ianfieldhouse wants to merge 9 commits intoedina:masterfrom
ianfieldhouse:upgrade-rn-work
Conversation
Merge changes from edina/CuriousEdinburgh2
Updated the app to support latest React Native version (version 0.59.9) at time of writing. - updated all dependencies and devDependencies - updated the iOS and Android project files so they contained the same files and file contents as a virgin React Native 0.59.9 project - updated app to build 64 bit binaries for Android
Update targetSdkVersion to 26 as this is the minimum allowed for the Play store now.
Updated build.gradle to force subprojects to use compileSdkVersion 29 and buildToolsVersion 29.0.0.
Added London as a simulated location for testing iOS
Using WebView for playing video on Android causes the video to simply play as in the thumbnail rather than full screen (like iOS. Previously this was worked around by creating an image thumbnail for the video, overlaying another image with a play button on it and then playing the video in the image modal. This was broken because it was embedding an <Image> element within another <Image> element. By replacing the outer <Image> element with a <ImageBackground> element we can work around this.
The pan to my location button doesn’t work in iOS (and Android??) after the work carried out to
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.