Skip to content

Conversation

@francoisTouchardEdifice
Copy link
Contributor

No description provided.

Copy link
Collaborator

@vmourot vmourot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attention à ne pas modifier les signatures des fonctions si possible.
Le premier argument est en général la session, même si rarement utilisé en pratique.

@vmourot vmourot marked this pull request as draft November 3, 2025 15:43
@francoisTouchardEdifice francoisTouchardEdifice force-pushed the feat/schoolbook-module-fetch-update branch 2 times, most recently from 1149114 to 366da4b Compare November 3, 2025 17:51
@francoisTouchardEdifice francoisTouchardEdifice marked this pull request as ready for review November 3, 2025 17:51
@thegdznet thegdznet deleted the branch dev/1.16.3 November 17, 2025 11:36
@thegdznet thegdznet closed this Nov 17, 2025
@vmourot vmourot reopened this Nov 24, 2025
@vmourot vmourot changed the base branch from dev/1.16.1 to dev/1.16.2 November 24, 2025 16:17
const api = `/schoolbook/list`;
const body = JSON.stringify({ filter: 'Any', page });
const entcoreTeacherWordList = (await signedFetchJson(`${session?.platform!.url}${api}`, {
const entcoreTeacherWordList = await sessionFetch.json<IEntcoreTeacherWordList>(`${session?.platform!.url}${api}`, {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retirer session?.platform!.url car sessionFetch le gère automatiquement

const api = `/schoolbook/relation/acknowledge/${wordId}/${studentId}`;
return signedFetchJson(`${session?.platform!.url}${api}`, {

return sessionFetch.json<Promise<{ id: number }>>(`${session?.platform!.url}${api}`, {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retirer session?.platform!.url car sessionFetch le gère automatiquement

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Pas besoin de typer avec Promise car la fonction est asynchrone

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok fait

const api = `/schoolbook/delete/${wordId}`;
return signedFetchJson(`${session?.platform!.url}${api}`, {

return sessionFetch.json<Promise<{ rows: number }>>(`${session?.platform!.url}${api}`, {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retirer session?.platform!.url car sessionFetch le gère automatiquement

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Pas besoin de typer avec Promise car la fonction est asynchrone

const body = JSON.stringify({ studentId, text });
return signedFetchJson(`${session?.platform!.url}${api}`, {

return sessionFetch.json<Promise<{ response_id: number }>>(`${session?.platform!.url}${api}`, {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem que pour les messages précédents

const api = `/schoolbook/word/resend/${wordId}`;
return signedFetchJson(`${session?.platform!.url}${api}`, {

return sessionFetch.json<Promise<{ count: number; word_id: string }>>(`${session?.platform!.url}${api}`, {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem que pour les messages précédents

const body = JSON.stringify({ text });
return signedFetchJson(`${session?.platform!.url}${api}`, {

return sessionFetch.json<Promise<{ rows: number }>>(`${session?.platform!.url}${api}`, {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem que pour les messages précédents

@thegdznet thegdznet deleted the branch dev/1.16.3 November 27, 2025 14:24
@thegdznet thegdznet closed this Nov 27, 2025
@francoisTouchardEdifice francoisTouchardEdifice force-pushed the feat/schoolbook-module-fetch-update branch 2 times, most recently from 701376b to 1fc1aba Compare December 1, 2025 11:04
@francoisTouchardEdifice francoisTouchardEdifice changed the base branch from dev/1.16.2 to dev/1.16.3 December 1, 2025 11:08
@francoisTouchardEdifice francoisTouchardEdifice force-pushed the feat/schoolbook-module-fetch-update branch from 1fc1aba to 0801dca Compare December 16, 2025 11:32
@francoisTouchardEdifice francoisTouchardEdifice force-pushed the feat/schoolbook-module-fetch-update branch from 0801dca to 379e27c Compare December 16, 2025 11:39
@sonarqubecloud
Copy link

@vmourot vmourot merged commit 0d086f0 into dev/1.16.3 Dec 17, 2025
2 checks passed
@francoisTouchardEdifice francoisTouchardEdifice deleted the feat/schoolbook-module-fetch-update branch December 17, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants