[16.0] account_invoice_transmit_peppol: Speedup and indepotent#14
Draft
lmignon wants to merge 1 commit intoedido-eu:16.0from
Draft
[16.0] account_invoice_transmit_peppol: Speedup and indepotent#14lmignon wants to merge 1 commit intoedido-eu:16.0from
lmignon wants to merge 1 commit intoedido-eu:16.0from
Conversation
lmignon
force-pushed
the
16.0-account_invoice_transmit_peppol-one-transfer-job
branch
4 times, most recently
from
876f66f to
7ca0da0
Compare
jbaudoux
reviewed
Jan 22, 2026
Comment on lines
15
to
16
| not self.is_move_sent | ||
| and not self.invoice_exported |
Contributor
There was a problem hiding this comment.
Allow resending in case of delivery failure
Suggested change
| not self.is_move_sent | |
| and not self.invoice_exported | |
| not invoice_export_confirmed |
jbaudoux
reviewed
Jan 22, 2026
| priority=40, | ||
| channel="root.invoice_transmit.peppol", | ||
| )._transmit_invoice_by_peppol() | ||
| if not invoice._is_transmissible_by_peppol(): |
Contributor
There was a problem hiding this comment.
Maybe generate a first job calling
to update invoice_export_confirmed
Contributor
Author
There was a problem hiding this comment.
We should create a delayable method on the invoice itself to check its status...
Contributor
There was a problem hiding this comment.
That sounds a good idea if invoice_export is True. That would be a limited number of case
* Uses the invoice's name into the job description in place of the dislay_name since the last one consume a lot of ressources to be computed * Makes the delayed method idempotent
lmignon
force-pushed
the
16.0-account_invoice_transmit_peppol-one-transfer-job
branch
from
7ca0da0 to
9437113
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.