Conversation
Rough table summarising single site analysis results; minor changes to make error reporting consistent.
Table of metrics from all analyses produced as separate final analysis, with winner for each metric (from model and benchmarks) highlighted. Third single site benchmark added for testing.
Taylor diagram plot had month_start days hard coded when a function in timing_general.R already had this information.
Month start change from previous change had a bug - month length needed indexing.
PDF overlap metric also renamed, bias metric from timeseries analysis introduced.
Line thickness changes as well.
In cases when a benchmark is dropped, colours across single site plots may become inconsistent for benchmarks - fixed for scatter plot. Added LegendText and BenchmarkColour functions as part of doing this. Created separate file for colour functions.
Across all single site analyses, plot colours could be different for the same benchmark (e.g. user’s 3rd benchmark) if an earlier nominated (i.e. 1st or 2nd bench) had failed (e.g. variable didn’t exist). This problem has now been fixed!
Plus minor changes to pass latitude and longitude information so that analysis will fail when model and obs are incompatible.
Just because NetcdfCompatibility.R is a more apprpriate place for it. Also added variable ranges to GetVariableDetails function and removed unused variable ranges function.
Needs to be constructed carefully - positioned well now, but doing nothing!
Plus minor changes to functions to get spatial grid.
and uses reduced saturation colours for daily averages
Makes function to compare obs$grid and model$grid more transparent.
In prep for adding global analysis. Moved metric functions to new file. Conceptually clearer, and a tad faster.
Also made execution a tad faster
Also fixes to allow for 0 user defined benchmarks
Using parallel calculation of metrics
Also made sure parallel metrics can be switched on or off from main analysis file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First cleanly executing global and aus regional analysis scripts