Skip to content

Conversation

@asheplyakov
Copy link

drivers/net/ethernet/baikal/xgbe/xgbe-drv.c: In function ‘xgbe_poll_controller’:
drivers/net/ethernet/baikal/xgbe/xgbe-drv.c:1655:4: error: implicit declaration of function ‘xgbe_dma_isr’; did you mean ‘xgbe_dma_rx_isr’? [-Werror=implicit-function-declara
tion]
    xgbe_dma_isr(channel->dma_irq, channel);
    ^~~~~~~~~~~~
    xgbe_dma_rx_isr
drivers/net/ethernet/baikal/xgbe/xgbe-drv.c:1655:26: error: ‘struct xgbe_channel’ has no member named ‘dma_irq’; did you mean ‘tx_dma_irq’?
    xgbe_dma_isr(channel->dma_irq, channel);
                          ^~~~~~~
                          tx_dma_irq
drivers/net/ethernet/baikal/xgbe/xgbe-drv.c: At top level:
drivers/net/ethernet/baikal/xgbe/xgbe-drv.c:1756:19: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
  .ndo_setup_tc  = xgbe_setup_tc,
                   ^~~~~~~~~~~~~
drivers/net/ethernet/baikal/xgbe/xgbe-drv.c:1756:19: note: (near initialization for ‘xgbe_netdev_ops.ndo_setup_tc’)
drivers/net/ethernet/baikal/xgbe/xgbe-mdio.c: In function ‘be_xgbe_xmit_probe’:
drivers/net/ethernet/baikal/xgbe/xgbe-mdio.c:545:10: error: ‘struct phy_device’ has no member named ‘dev’; did you mean ‘drv’?
  phydev->dev.of_node = xmit_node;
          ^~~
          drv
drivers/net/ethernet/baikal/xgbe/xgbe-mdio.c:549:22: error: ‘struct phy_device’ has no member named ‘dev’; did you mean ‘drv’?
  put_device(&phydev->dev);
                      ^~~
                      drv

The driver compiles and successfully loads, however I haven't tested if the interface is operational (for I have no other 10Gb NICs/switches)

Fixes the following error:

drivers/net/ethernet/baikal/xgbe/xgbe-drv.c: In function ‘xgbe_poll_controller’:
drivers/net/ethernet/baikal/xgbe/xgbe-drv.c:1655:4: error: implicit declaration of function ‘xgbe_dma_isr’; did you mean ‘xgbe_dma_rx_isr’? [-Werror=implicit-function-declara
tion]
    xgbe_dma_isr(channel->dma_irq, channel);
    ^~~~~~~~~~~~
    xgbe_dma_rx_isr
drivers/net/ethernet/baikal/xgbe/xgbe-drv.c:1655:26: error: ‘struct xgbe_channel’ has no member named ‘dma_irq’; did you mean ‘tx_dma_irq’?
    xgbe_dma_isr(channel->dma_irq, channel);
                          ^~~~~~~
Fixes the following compilation error:

drivers/net/ethernet/baikal/xgbe/xgbe-drv.c: At top level:
drivers/net/ethernet/baikal/xgbe/xgbe-drv.c:1756:19: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
  .ndo_setup_tc  = xgbe_setup_tc,
                   ^~~~~~~~~~~~~
drivers/net/ethernet/baikal/xgbe/xgbe-drv.c:1756:19: note: (near initialization for ‘xgbe_netdev_ops.ndo_setup_tc’)
drivers/net/ethernet/baikal/xgbe/xgbe-mdio.c: In function ‘be_xgbe_xmit_probe’:
drivers/net/ethernet/baikal/xgbe/xgbe-mdio.c:545:10: error: ‘struct phy_device’ has no member named ‘dev’; did you mean ‘drv’?
  phydev->dev.of_node = xmit_node;
          ^~~
          drv
drivers/net/ethernet/baikal/xgbe/xgbe-mdio.c:549:22: error: ‘struct phy_device’ has no member named ‘dev’; did you mean ‘drv’?
  put_device(&phydev->dev);
                      ^~~
                      drv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant