New fork with unmasked/photo foucault.#25
Conversation
|
Thanks , can you please add a small set of image + foucault2 files in the sample folder so user can play with it ? |
| @@ -0,0 +1,10 @@ | |||
|
|
|||
There was a problem hiding this comment.
ok to convert in english or move them into the github issues ?
|
|
||
|
|
||
|
|
||
| // double _dSlit_angle; |
There was a problem hiding this comment.
Code is nice, I just argued on some coding style, thanks!
However, there is maybe a missing part, the connection to the main App ?
I think we can merge quickly , I will test and restest with you samples data , also gives it to the Sorbonne Observatory so they can test it,
and then a other release maybe cleanup
Thanks
| ui->dateTimeEdit->setTime(QTime::currentTime()); | ||
| set_mirror_total_diameter( _pMirror->diameter() ); | ||
| // _dMirror_angle =0.; | ||
| _dNumber_of_images = ui->le_nb_img->text().toDouble(&bSuccess); |
| resize_vectors(); | ||
| _dDeltaHx =0.5; | ||
| _dName_format_n =7; | ||
| _dName_format_n =3; |
| // _dMirror_angle =0.; | ||
| _dNumber_of_images = ui->le_nb_img->text().toDouble(&bSuccess); | ||
| resize_vectors(); | ||
| _dDeltaHx =0.5; |
There was a problem hiding this comment.
Hard coded value ? Please add a comment
| float DialogNewUnmaskedMeasure::get_slit_angle() | ||
| { | ||
| bool bSuccess; | ||
| return ui->leSlitAngle->text().toFloat(&bSuccess); |
| } else { | ||
| QMessageBox::critical(this,tr("Error"),tr("Images number should be at least 3.)")); | ||
| ui->le_nb_img->setText( QString::number( _dNumber_of_images) ); | ||
| // ui->le_nb_img->setFocus(); |
| for( i = _dNumber_of_images; i < MaxZones; i++ ) | ||
| { | ||
| images_set.clear_image( i ); | ||
| }; |
| int i; | ||
| images_set.set_rotation( get_slit_angle() ); | ||
| _STATE = STATE_INIT; | ||
| for( i = _dNumber_of_images; i < MaxZones; i++ ) |
| // | ||
| QProgressDialog progress("Loading images...", "continue", 0, _dNumber_of_images, this); | ||
| progress.setWindowModality(Qt::WindowModal); | ||
| /* |
| { | ||
| _STATE = STATE_CROPPING ; | ||
|
|
||
| // CHARGEMENT IMAGES |
| _STATE = STATE_ANALYZING ; | ||
| QProgressDialog progress("Searching zones...", "continue", 0, _dNumber_of_images, this); | ||
| progress.setWindowModality(Qt::WindowModal); | ||
| /* |
src/DialogNewUnmaskedMeasure.cpp
Outdated
| return (a.hm < b.hm); | ||
| } | ||
| }; | ||
| static std::vector < hx_hm > v_hx_hm; |
There was a problem hiding this comment.
Do we really need statics ? It will have conflict if two Unmasked measures exist?
src/DialogNewUnmaskedMeasure.cpp
Outdated
| }; | ||
| static std::vector < hx_hm > v_hx_hm; | ||
|
|
||
| // v_hx_mx.push_back(hx_mx( hx , hm)); |
| } | ||
| /* | ||
|
|
||
| { |
| } | ||
| void DialogNewUnmaskedMeasure::on_pushButton_cancel_clicked() | ||
| { | ||
| printf("cancel - "); |
There was a problem hiding this comment.
Remove since A console maybe flash for this printf ?
|
|
||
| vector<double> DialogNewUnmaskedMeasure::get_Img_hx() | ||
| { | ||
| /* if((_STATE == STATE_CROPPING )||(_STATE == STATE_ANALYZING )) |
src/DialogNewUnmaskedMeasure.cpp
Outdated
| return _Img_Hx; | ||
| } | ||
| ////////////////////////////////////////////////////////////////////// | ||
| /*void DialogNewUnmaskedMeasure::on_btnComputeNbOfzone_clicked() |
| @@ -0,0 +1,102 @@ | |||
| #include "TaskItemUnmaskedMeasure.h" | |||
| #include "Mirror.h" | |||
| // #include "MirrorCouderMeasure.h" | |||
| } | ||
|
|
||
| ///////////////////////////////////////////////////////////// | ||
| // ALGO TO FIND THE CENTER: |
| return true; | ||
| } | ||
|
|
||
| class table_trigo |
There was a problem hiding this comment.
Not sur is it quicker than direct computation ...
|
|
||
|
|
||
|
|
||
| // double _dSlit_angle; |
There was a problem hiding this comment.
Code is nice, I just argued on some coding style, thanks!
However, there is maybe a missing part, the connection to the main App ?
I think we can merge quickly , I will test and restest with you samples data , also gives it to the Sorbonne Observatory so they can test it,
and then a other release maybe cleanup
Thanks
(ajout de clear sur les vecteurs). Ajout d'un exemple simule avec Difract dans sample.
…tion of the radius by top and bottom detection before 3 points circle algo. Testing, zone minimal values are greater near the edge than in the center. It is now used to valid or unvalid minimas as zones..
… émission de messages.
2 participants
No description provided.