fix: collapse sheet on navitation change#482
Open
tvillega wants to merge 1 commit intoeddyizm:developmentfrom
Open
fix: collapse sheet on navitation change#482tvillega wants to merge 1 commit intoeddyizm:developmentfrom
tvillega wants to merge 1 commit intoeddyizm:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intended behavior of the bottom navigation bar is to collapse the bottom sheet when the user navigates to another location (Home, Library or Downloads).
The navigation drawer allows the user to navigate to new locations, however the bottom sheet was not instructed to collapse when recognizing that transition, loading the fragment behind the expanded bottom sheet.
This PR makes the bottom sheet collapse when accessing all the menu items of the drawer.