You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When two consecutive lines in the lyrics have the same timestamp, both lines will be highlighted simultaneously. This is to support the display of lyrics that include translated text.
Hi @sffzh ,
I tested this today and even though I don't have any lyrics with 2 lines, it seems to have broken the single line lyrics.
I tested on the ampache demo server to see the diff between this PR and the current dev build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugSomething isn't workingneeds testingRequires some manual testing and validation.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When two consecutive lines in the lyrics have the same timestamp, both lines will be highlighted simultaneously. This is to support the display of lyrics that include translated text.