fix: Robin materializer empty schema edge case (#475)#485
Merged
eddiethedean merged 1 commit intov4.0.0from Feb 12, 2026
Merged
fix: Robin materializer empty schema edge case (#475)#485eddiethedean merged 1 commit intov4.0.0from
eddiethedean merged 1 commit intov4.0.0from
Conversation
- When schema.fields is empty and operations is empty, return data as rows (no-op) instead of raising. - When schema is empty but operations are present, raise a clear ValueError. - Add TestRobinMaterializerEmptySchema with tests for both cases. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #475: handle empty schema in Robin materializer deterministically.
Changes
schema.fieldsis empty:operationsis empty: return data as list of rows (no-op), using_data_to_robin_rows(data, [])and wrapping inRow(..., schema=schema).operationsis non-empty: raise a clearValueErrorwith message "Robin backend does not support empty schema when operations are applied; ensure at least one column."TestRobinMaterializerEmptySchemawith:test_empty_schema_no_operations_returns_rows:materialize([], StructType([]), [])returns[].test_empty_schema_with_operations_raises:materialize([], StructType([]), [("limit", 5)])raisesValueErrormatching "does not support empty schema when".Made with Cursor