test: verify Robin concat(col, lit, col) uses materializer (#474)#484
Merged
eddiethedean merged 2 commits intov4.0.0from Feb 12, 2026
Merged
test: verify Robin concat(col, lit, col) uses materializer (#474)#484eddiethedean merged 2 commits intov4.0.0from
eddiethedean merged 2 commits intov4.0.0from
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #474 by adding a Robin backend test that verifies
concat(col, lit(sep), col)is translated correctly (via the existing concat → concat_ws logic in the materializer).Changes
test_concat_with_literal_separator_robin, which uses the Robin backend to run:df.withColumn("full_name", F.concat(F.col("first_name"), F.lit(" "), F.col("last_name")))full_namevalues are"alice x"and"bob y".The materializer already contains a concat branch that detects exactly one string
Literalamong the parts and routes toconcat_ws; this test ensures that behavior is covered in CI for the Robin backend.Made with Cursor