fix: Robin backend join materializer and plan path support (#473)#483
Merged
eddiethedean merged 2 commits intov4.0.0from Feb 12, 2026
Merged
fix: Robin backend join materializer and plan path support (#473)#483eddiethedean merged 2 commits intov4.0.0from
eddiethedean merged 2 commits intov4.0.0from
Conversation
- Skip Robin plan path when queue contains join or union; use materializer (op path) directly so join no longer hits 'Operation join is not supported'. - Document in materializer that different-name join keys are not supported. - Add test_join_same_name_on_robin for left.join(right, on='id', how='inner'). - Document in v4_behavior_changes: join op path only, same-name keys supported, different-name keys not supported. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #473: join no longer raises
SparkUnsupportedOperationError: Operation 'Operations: join' is not supportedwhen using the Robin backend with same-name join keys.Changes
joinorunion, skip the Robin plan path and run the materializer (op path) directly. This avoidsto_robin_planraising for join and ensures join is handled only by the materializer, which already supports same-nameon._join_on_to_column_namesthat different-name join keys (e.g.left["id"] == right["id_right"]) are not supported; same-nameonoron="col"/on=["c1", "c2"]are supported.test_join_same_name_on_robinthat runsleft.join(right, on="id", how="inner").collect()with Robin and asserts row count and contents.Expected behavior (per issue)
left.join(right, on="id", how="inner")runs on the op path and returns joined rows when backend is Robin.Made with Cursor