Fix orderBy with desc/asc column specs in Robin plan executor#478
Merged
eddiethedean merged 2 commits intov4.0.0from Feb 12, 2026
Merged
Fix orderBy with desc/asc column specs in Robin plan executor#478eddiethedean merged 2 commits intov4.0.0from
eddiethedean merged 2 commits intov4.0.0from
Conversation
- Handle {"op": "desc"|"asc"|..., "left": {"col": name}} in orderBy payload
- Extract column name from left and set ascending from op (desc* -> False, else True)
- Keep support for plain {"col": name} with payload ascending list
- Fixes ValueError: orderBy currently supports only column references in plan
Co-authored-by: Cursor <cursoragent@cursor.com>
- Add real, executable examples and captured outputs to lazy evaluation and configuration guides - Extend Robin plan executor tests to cover orderBy with desc/asc and mixed specs - Refresh full failure classification notes from latest Robin backend test run Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #468
Summary
The plan executor only accepted
{"col": name}for orderBy columns and raised when it received{"op": "desc", "left": {"col": "salary"}}fromF.col("salary").desc().Changes
plan_executor.pyorderBy branch: for each column spec,{"col": name}→ use name and correspondingascendingfrom payload.{"op": "desc"|"asc"|... , "left": {"col": name}}→ useleft["col"]and set ascending from op (desc,desc_nulls_last,desc_nulls_first→ False; else True).col_namesandasc_listand calldf.order_by(col_names, asc_list)as before.Expected behavior
df.orderBy(F.col("salary").desc())now sorts bysalarydescending when using the Robin plan path.Made with Cursor