Open
Conversation
KenwoodFox
force-pushed
the
fix/no_render_context_fix
branch
2 times, most recently
from
50f46be to
96bfc78
Compare
KenwoodFox
force-pushed
the
fix/no_render_context_fix
branch
2 times, most recently
from
4825ea1 to
6b248dd
Compare
Owner
|
Wasn't the issue fixed by using the official binary? |
Author
Kindof! It was fixed with bundling in the official binary but not when built standalone from |
KenwoodFox
force-pushed
the
fix/no_render_context_fix
branch
from
6b248dd to
d105788
Compare
…r setVisible i 'think' mpv gets called too early and before drawing we get that 'no render context set' if we wrap a promise around scheduling just one frame it holds it and seems to work for me, since the context is ready by the time it continies. Maybe that wait could be integrated into the setvisible?
KenwoodFox
force-pushed
the
fix/no_render_context_fix
branch
from
d105788 to
fc8d89a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue for me but might not be the right solution, after setVisible i 'think' mpv gets called too early and before drawing we get that 'no render context set' if we wrap a promise around scheduling just one frame it holds it and seems to work for me, since the context is ready by the time it continues.
Maybe that wait could be integrated into the setVisible?
plezy/lib/mpv/player/player_native.dart
Line 122 in 4cc8300