Add Makefile overrides for install kpt macro w/ retries#4
Merged
Conversation
kaelemc
changed the title
There was a problem hiding this comment.
Pull request overview
This PR adds Makefile overrides to implement retry logic for kpt package installations in the GitHub Codespaces development environment. The changes aim to improve reliability when deploying to Kubernetes in potentially unstable codespace environments.
Changes:
- Created new Makefile override file with retry logic for kpt live apply operations
- Refactored container image pre-pulling from onCreate to postCreate phase
- Updated devcontainer configuration with new environment variables and settings
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
.devcontainer/overrides.mk |
New file implementing INSTALL_KPT_PACKAGE macro with 5 retry attempts and 3-minute reconcile timeout |
.devcontainer/postCreate.sh |
Added image pre-pulling logic and updated make command to use override file |
.devcontainer/onCreate.sh |
Removed image pre-pulling logic (moved to postCreate) |
.devcontainer/devcontainer.json |
Added environment variables, updated base image tag to test version, modified VS Code settings |
.devcontainer/Dockerfile |
Changed to use specific version tag (v0.0.1) from forked repository |
.devcontainer/shell/starship.toml |
Removed symbol configurations and disabled kubernetes module in shell prompt |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "containerEnv": { | ||
| "EDA_PORT": "9443" | ||
| "EDA_PORT": "9443", | ||
| "TRY_EDA_OVERRIDES_FILE": "/workspaces/codespaces/.devcontainer/overrides.mk", |
There was a problem hiding this comment.
The hardcoded path "/workspaces/codespaces/.devcontainer/overrides.mk" assumes a specific workspace structure. Consider making this path configurable or using a relative path to improve portability.
Suggested change
| "TRY_EDA_OVERRIDES_FILE": "/workspaces/codespaces/.devcontainer/overrides.mk", | |
| "TRY_EDA_OVERRIDES_FILE": "${containerWorkspaceFolder}/.devcontainer/overrides.mk", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.