Skip to content

Support PyPI Trusted Publisher for making releases#1551

Merged
MridulS merged 1 commit intoecon-ark:masterfrom
MridulS:add_ci_release_action
Oct 30, 2025
Merged

Support PyPI Trusted Publisher for making releases#1551
MridulS merged 1 commit intoecon-ark:masterfrom
MridulS:add_ci_release_action

Conversation

@MridulS
Copy link
Member

@MridulS MridulS commented May 7, 2025

Fixes #708

Keeping it in draft mode for now as we still need to turn on trusted publisher on pypi side https://docs.pypi.org/trusted-publishers/adding-a-publisher. I can do that if folks think we should go ahead with this :)

@MridulS MridulS marked this pull request as draft May 7, 2025 21:43
@mnwhite
Copy link
Contributor

mnwhite commented May 10, 2025

So the idea is that rather than doing the old process of manually pushing to PyPI and concurrently making a release commit / tagging a version on GitHub, we would just do a version tag here and that would automatically propagate to a PyPI release?

@MridulS
Copy link
Member Author

MridulS commented May 10, 2025

we would just do a version tag here and that would automatically propagate to a PyPI release?

Indeed! This is the recommended security practice too now.

@mnwhite
Copy link
Contributor

mnwhite commented May 11, 2025

@llorracc @akshayshanker @alanlujan91 See above. I vote for this.

@llorracc
Copy link
Collaborator

@MridulS, thanks for the input. This sounds like a good idea.

@mnwhite
Copy link
Contributor

mnwhite commented May 14, 2025

Alan pointed out that this change is part of the (oddly named) PR #1514. The current plan is that after we release v0.16.0, we will then quickly do v0.16.1 with only packaging / technology changes. So let's put this on hold for (hopefully) a short while.

@alanlujan91
Copy link
Member

@mnwhite
Copy link
Contributor

mnwhite commented May 14, 2025

I'm sure it means something, but my point is that the one word title with no verb isn't clear. My understanding/definition of "cookie" is:

  1. the round sweetdiscs that we om-nom-nom
  2. a file that websites deposit in your webcache

The cookie PR is related to neither, and the word "cookie" doesn't appear in the description anywhere.

@MridulS
Copy link
Member Author

MridulS commented May 14, 2025

@alanlujan91 I was just overwhelmed by looking at all the merge conflicts it will create so trying to move in baby steps :D

@mnwhite mnwhite marked this pull request as ready for review October 30, 2025 19:36
@mnwhite
Copy link
Contributor

mnwhite commented Oct 30, 2025

@MridulS Can this be merged? Simplifying the release workflow would be great.

@MridulS
Copy link
Member Author

MridulS commented Oct 30, 2025

I set it up on pypi side too, we can test it out with the next release. Ideally shouldn't really break anything :)

If anything does go wrong, the release can be uploaded manually!

@MridulS MridulS merged commit 5e41b23 into econ-ark:master Oct 30, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

automate PyPI/conda release using GitHub Actions.

4 participants