Conversation
There was a problem hiding this comment.
The plots here look different (in cell 33), is this expected?
There was a problem hiding this comment.
Cell 17 and Cell 25 have different plots too.
There was a problem hiding this comment.
Cell 15 and Cell 22 have different plots too
There was a problem hiding this comment.
Simulation plots are different here too.
|
What's the easiest way to see these differences? Open the branch locally?
…On Wed, Mar 5, 2025 at 4:00 PM Mridul Seth ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On examples/ConsumptionSaving/example_ConsGenIncProcessModel.ipynb
<#1542 (comment)>:
Simulation plots are different here too.
—
Reply to this email directly, view it on GitHub
<#1542 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKRAFIK6ZIDYMPINJDSPJT2S5QXRAVCNFSM6AAAAABYGJADSOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNRSGQ3TQMBXGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
There was a problem hiding this comment.
Significant changes in the plot here too.
With so many notebooks, I'm not sure. I am just looking at the "rich diff" on github interface while comparing old plots with these new runs. |
MridulS
left a comment
There was a problem hiding this comment.
Another broad observation is that all the timing numbers look way slower now, I'm not sure if the machines are less powerful on github actions now or HARK got slower? Or maybe these timing numbers are from local machines.
c45bbf7 to
74666e9
Compare
74666e9 to
f623117
Compare
f623117 to
e02a740
Compare
c9587bf to
7b54cc4
Compare
7b54cc4 to
2c708ce
Compare
2c708ce to
a036f80
Compare
aef7d38 to
cdd51e9
Compare
4c769f8 to
361a20d
Compare
61f903c to
77ea33b
Compare
5fe30bd to
7b0193b
Compare
7b0193b to
a394b16
Compare
679779a to
f695a71
Compare
f695a71 to
81e3ee8
Compare
81e3ee8 to
5ba86ab
Compare
5ba86ab to
45bd84c
Compare
45bd84c to
3415732
Compare
c7e1710 to
67ef54f
Compare
b441dbc to
68864ae
Compare
2092f06 to
0c639c1
Compare
304662e to
4b15ed0
Compare
f0b784a to
2e2dd5d
Compare
2e2dd5d to
4890948
Compare
4890948 to
eb4a934
Compare
eb4a934 to
5692f4b
Compare
3bdebc1 to
6ac2734
Compare
6ac2734 to
745f4fe
Compare
53fe7b4 to
5efb6ee
Compare
67d988b to
90cf2c6
Compare
There was a problem hiding this comment.
Pull request overview
This pull request was automatically generated to re-execute the example notebooks for use in the documentation. The changes are produced by an automated workflow that strips notebook outputs and re-executes all example notebooks using Python 3.10.
Changes:
- Standardized all notebook cell IDs to sequential numeric strings ("0", "1", "2", etc.)
- Updated Python version metadata from various versions (3.11.9, 3.12.9) to 3.10.19 across all notebooks
- Refreshed notebook execution outputs including memory addresses, timing results, and plot images
Reviewed changes
Copilot reviewed 14 out of 63 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| examples/SequenceSpaceJacobians/SSJ_explanation.ipynb | Cell IDs standardized, Python version updated to 3.10.19 |
| examples/Journeys/Journeys-into-HARK.ipynb | Python version updated from 3.11.9 to 3.10.19 |
| examples/Journeys/Journey-Engineering-Background.ipynb | Python version updated from 3.12.9 to 3.10.19 |
| examples/Gentle-Intro/Model-List.ipynb | Cell IDs standardized, Python version updated to 3.10.19 |
| examples/Gentle-Intro/Market-Intro.ipynb | Cell IDs standardized, Python version updated to 3.10.19 |
| examples/Gentle-Intro/Constructors-Intro.ipynb | Cell IDs standardized, memory addresses updated, Python version updated to 3.10.19 |
| examples/Gentle-Intro/AgentType-Intro.ipynb | Cell IDs standardized, Python version updated to 3.10.19 |
| examples/Distributions/DiscreteDistributionLabeled.ipynb | Execution metadata removed, xarray CSS updated, timing results refreshed, Python version updated to 3.10.19 |
| examples/ConsBequestModel/example_AccidentalBequestComp.ipynb | Execution metadata removed, plot image updated, Python version updated to 3.10.19 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
90cf2c6 to
d9f4367
Compare
d9f4367 to
cac4998
Compare
cac4998 to
bef16b8
Compare
bef16b8 to
7dd7d91
Compare
7dd7d91 to
32095cf
Compare
This PR was [automatically generated] to re-execute the example notebooks for use in the documentation.
[automatically generated]: https://github.com/Econ-ARK/HARK/actions/workflows/execute-notebooks.yml