Skip to content

Add RamseyCassKoopmans and Prescott RBC notebooks and markdown files#234

Open
nathanrobino wants to merge 16 commits intoecon-ark:mainfrom
nathanrobino:two-new-notebooks-and-markdown-files-from-llorracc-jupyter-repot
Open

Add RamseyCassKoopmans and Prescott RBC notebooks and markdown files#234
nathanrobino wants to merge 16 commits intoecon-ark:mainfrom
nathanrobino:two-new-notebooks-and-markdown-files-from-llorracc-jupyter-repot

Conversation

@nathanrobino
Copy link
Collaborator

These two notebooks were from https://github.com/llorracc/Jupyter to be consolidated into DemARK.

@llorracc llorracc self-requested a review January 23, 2026 17:06
@alanlujan91 alanlujan91 requested a review from Copilot January 26, 2026 20:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds DemARK metadata/landing markdown files for several existing Jupyter notebooks so they can be integrated into the documentation/site.

Changes:

  • Introduces metadata page for the Prescott RBC DSGE model notebook.
  • Adds metadata pages for Ramsey/Cass-Koopmans, Portfolio CRRA, Palgrave Precautionary Saving, and Equiprobable approximation notebooks.
  • Links each markdown file to its corresponding notebook and authorship/ORCID information.

Reviewed changes

Copilot reviewed 5 out of 333 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
markdown/The-Prescott-Real-Business-Cycle-RBC.md New metadata and landing page for the Prescott RBC notebook.
markdown/RamseyCassKoopmans.md New metadata and landing page for the Ramsey/Cass-Koopmans notebook.
markdown/PortfolioCRRA.md New metadata and landing page for the Portfolio CRRA notebook.
markdown/PalgravePrecautionary.md New metadata and landing page for the Palgrave Precautionary Saving notebook.
markdown/Equiprobable.md New metadata and landing page for the Equiprobable approximation notebook.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mnwhite
Copy link
Collaborator

mnwhite commented Jan 26, 2026

I should have said this before: because I'm not sure what the intended scope is here, just ping me when this PR is ready for review. Or: please @ me, bro.

@nathanrobino
Copy link
Collaborator Author

@mnwhite Chris and I were working to merge this big PR but running into problems (as you can see).

Now that I'm no longer up to date with the upstream branch I'm getting worried I'm going to break something. Will update you

@mnwhite
Copy link
Collaborator

mnwhite commented Jan 27, 2026 via email

@mnwhite
Copy link
Collaborator

mnwhite commented Jan 27, 2026

I'll take a look at the one notebook failure momentarily. On first glance, my guess is it's some quirk of the widget syntax, which can be weird.

But the big thing is that this PR does a lot more than what the title says (adding notebooks from another CDC repo). It adds 300+ figure files from basically all of the other DemARKs, I think by somehow running savefigs on every single graphical output. I don't think we want to do this, and I'm not even sure you meant to do this.

@nathanrobino
Copy link
Collaborator Author

So I agree this is much more than the original PR's title -- as Chris asked for more changes I just kept adding them to the same branch (I'm quickly learning this is bad practice). I can look into ways to split it up into smaller pieces.

Chris did specifically ask for me to save all of the figures into a folder with all of the various filetypes using the make_figs HARK command

mnwhite and others added 2 commits January 29, 2026 14:36
Cells with dynamic output can confuse nbval.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@mnwhite
Copy link
Collaborator

mnwhite commented Jan 29, 2026

The only change I made was to add a metadata tag to the one cell that was failing the nbval check. Google says that nbval can get upset/confused about cells that have dynamic output, like interactive graphs / widgets, and that the solution is to just ignore that cell.

@nathanrobino
Copy link
Collaborator Author

@llorracc Matt helped me get this ready to go. It's ready to merge, pending your review.

@mnwhite
Copy link
Collaborator

mnwhite commented Jan 29, 2026

Can I ask why we want every single notebook's figures to be stored in the repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants