Add RamseyCassKoopmans and Prescott RBC notebooks and markdown files#234
Conversation
There was a problem hiding this comment.
Pull request overview
Adds DemARK metadata/landing markdown files for several existing Jupyter notebooks so they can be integrated into the documentation/site.
Changes:
- Introduces metadata page for the Prescott RBC DSGE model notebook.
- Adds metadata pages for Ramsey/Cass-Koopmans, Portfolio CRRA, Palgrave Precautionary Saving, and Equiprobable approximation notebooks.
- Links each markdown file to its corresponding notebook and authorship/ORCID information.
Reviewed changes
Copilot reviewed 5 out of 333 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| markdown/The-Prescott-Real-Business-Cycle-RBC.md | New metadata and landing page for the Prescott RBC notebook. |
| markdown/RamseyCassKoopmans.md | New metadata and landing page for the Ramsey/Cass-Koopmans notebook. |
| markdown/PortfolioCRRA.md | New metadata and landing page for the Portfolio CRRA notebook. |
| markdown/PalgravePrecautionary.md | New metadata and landing page for the Palgrave Precautionary Saving notebook. |
| markdown/Equiprobable.md | New metadata and landing page for the Equiprobable approximation notebook. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I should have said this before: because I'm not sure what the intended scope is here, just ping me when this PR is ready for review. Or: please @ me, bro. |
…s-from-llorracc-jupyter-repot
|
@mnwhite Chris and I were working to merge this big PR but running into problems (as you can see). Now that I'm no longer up to date with the upstream branch I'm getting worried I'm going to break something. Will update you |
|
You probably won't break anything. Alan did some repo maintenance that
*shouldn't* affect this PR. I'll check with him tomorrow on this.
I'll also try to look at the failures here and see if I can help.
…On Mon, Jan 26, 2026, 10:43 PM Nathan Robino ***@***.***> wrote:
*nathanrobino* left a comment (econ-ark/DemARK#234)
<#234 (comment)>
@mnwhite <https://github.com/mnwhite> Chris and I were working to merge
this big PR but running into problems (as you can see).
Now that I'm no longer up to date with the upstream branch I'm getting
worried I'm going to break something. Will update you
—
Reply to this email directly, view it on GitHub
<#234 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKRAFPBONMDVUDAFWYPL434I3NENAVCNFSM6AAAAACQ7BPVDKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQMBSHEYTGNJYGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I'll take a look at the one notebook failure momentarily. On first glance, my guess is it's some quirk of the widget syntax, which can be weird. But the big thing is that this PR does a lot more than what the title says (adding notebooks from another CDC repo). It adds 300+ figure files from basically all of the other DemARKs, I think by somehow running |
|
So I agree this is much more than the original PR's title -- as Chris asked for more changes I just kept adding them to the same branch (I'm quickly learning this is bad practice). I can look into ways to split it up into smaller pieces. Chris did specifically ask for me to save all of the figures into a folder with all of the various filetypes using the |
Cells with dynamic output can confuse nbval.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
The only change I made was to add a metadata tag to the one cell that was failing the nbval check. Google says that nbval can get upset/confused about cells that have dynamic output, like interactive graphs / widgets, and that the solution is to just ignore that cell. |
|
@llorracc Matt helped me get this ready to go. It's ready to merge, pending your review. |
|
Can I ask why we want every single notebook's figures to be stored in the repo? |
These two notebooks were from https://github.com/llorracc/Jupyter to be consolidated into DemARK.