refactor: remove unused code and redundant check in NonceManager#58
Merged
re1ro merged 2 commits intofeat/nonce-treefrom Nov 22, 2025
Merged
Conversation
Address PR feedback: - Remove unused hashNonceNode internal function - Remove redundant emptiness check (handled by hashNoncesToInvalidate) - Remove unused _sortBytes32Array helper function Changes: - Removed hashNonceNode function (only used tests via _hashNonceNode) - Removed redundant empty array check at line 164-166 - Removed orphaned _sortBytes32Array function after hashNonceNode removal - Simplified code by trusting hashNoncesToInvalidate to handle edge cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address PR feedback:
Changes: