Deprecate ecbuild_find_(mpi|omp).cmake macros#128
Open
marcosbento wants to merge 1 commit intodevelopfrom
Open
Deprecate ecbuild_find_(mpi|omp).cmake macros#128marcosbento wants to merge 1 commit intodevelopfrom
marcosbento wants to merge 1 commit intodevelopfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR marks the legacy ecbuild_find_mpi/ecbuild_find_omp-related macros as deprecated in favor of using CMake’s built-in FindMPI and FindOpenMP, aligning with Issue #126 and the broader move away from ecbuild-specific find wrappers.
Changes:
- Updated the RST-style documentation blocks in
ecbuild_find_mpi.cmakeandecbuild_find_omp.cmaketo clearly label the affected macros as deprecated and direct users toFindMPI/FindOpenMP. - Added runtime deprecation warnings inside the MPI-related macros (
ecbuild_find_mpi,ecbuild_enable_mpi,ecbuild_include_mpi) via a new helper call at macro entry. - Added runtime deprecation warnings inside the OpenMP-related macros (
ecbuild_find_omp,ecbuild_enable_omp,ecbuild_enable_ompstubs) via a new helper call at macro entry.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| cmake/ecbuild_find_omp.cmake | Adds documentation and runtime deprecation for ecbuild_find_omp, ecbuild_enable_omp, and ecbuild_enable_ompstubs to steer users toward CMake’s FindOpenMP. |
| cmake/ecbuild_find_mpi.cmake | Adds documentation and runtime deprecation for ecbuild_find_mpi, ecbuild_enable_mpi, and ecbuild_include_mpi to steer users toward CMake’s FindMPI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d740be7 to
bc4c94c
Compare
bc4c94c to
7f70520
Compare
wdeconinck
approved these changes
Feb 5, 2026
Member
wdeconinck
left a comment
There was a problem hiding this comment.
Thanks @marcosbento for pushing this further!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These changes deprecate
ecbuild_find_(mpi|omp).cmakemacros, in favour of directly usingFindMPIandFindOpenMP-- as suggested by #126.Contributor Declaration
By opening this pull request, I affirm the following: