fix(export): address review comments from #3444#4012
Open
amandx36 wants to merge 1 commit intoeclipse-sw360:mainfrom
Open
fix(export): address review comments from #3444#4012amandx36 wants to merge 1 commit intoeclipse-sw360:mainfrom
amandx36 wants to merge 1 commit intoeclipse-sw360:mainfrom
Conversation
amandx36
requested review from
GMishx,
KoukiHama,
ag4ums and
arunazhakesan
as code owners
- use jackson dependency from parent pom - add jackson-dataformat-xml to root pom - add license headers to export classes - remove unused parameter (rootType) - remove commented code - refactor duplicate export logic - fix failing test cases;wq
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the review comments from the previously closed PR #3444.
The original PR was closed due to inactivity. This PR implements all requested changes and improvements.
Issue
Ref: #3444
Changes
Dependencies
No new versions added manually.
Jackson dependencies are now aligned with the parent pom (${jackson.version}).
How To Test
Additional Notes
This PR is based on the review comments provided by @GMishx in #3444.
Checklist