generated from eclipse-score/module_template
-
Notifications
You must be signed in to change notification settings - Fork 2
scheduler: Fix bug in scheduling safety task #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
prabakaranklst
wants to merge
1
commit into
eclipse-score:main
Choose a base branch
from
qorix-group:prabakaran_fix_crash_due_to_safety_tasks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
scheduler: Fix bug in scheduling safety task #32
prabakaranklst
wants to merge
1
commit into
eclipse-score:main
from
qorix-group:prabakaran_fix_crash_due_to_safety_tasks
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
383e198 to
2d1640f
Compare
09a7db9 to
75b4719
Compare
75b4719 to
792e4e7
Compare
792e4e7 to
8d8d7b1
Compare
8d8d7b1 to
d14d4e5
Compare
d14d4e5 to
c3b2561
Compare
Fixed bugs related to handling and scheduling safety task. eclipse-score#18 eclipse-score#20 eclipse-score#39
c3b2561 to
3e7796d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the above scenario with safety worker enabled in runtime, after polling of Task-A which return error, it is detected as safety error and a
safety wakeris created from normal waker andwake()function is called. In the wake function, thewaker data ptris typecasted as (parent) task and further try to clone. But, there is no valid pointer in the task vtable for clone() and it results in segmentation fault.As fix, a thread local safety error flag is set instead of creating safety waker. When the wake function is called, it goes through Task-B and then our wake() function is executed. In this wake(), the safety error flag is checked and the task is scheduled on either safety or normal worker.
Notes for Reviewer
Pre-Review Checklist for the PR Author
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #18