Skip to content

Conversation

@merks
Copy link
Contributor

@merks merks commented Jul 5, 2025

  • The warning An entry for org.eclipse.platform/LegacyIDE.e4xmi is required in bin.includes can be avoided by using
    platform:/plugin/org.eclipse.platform/LegacyIDE.e4xmi instead.

- The warning `An entry for org.eclipse.platform/LegacyIDE.e4xmi is
required in bin.includes` can be avoided by using
`platform:/plugin/org.eclipse.platform/LegacyIDE.e4xmi` instead.
@merks
Copy link
Contributor Author

merks commented Jul 5, 2025

In this logic, it checks if the value starts with platform:/ in which case it directly creates the URI from the value rather than prefixing the value with platform:/plugin/:

https://github.com/eclipse-platform/eclipse.platform.ui/blob/d2177cf040d9394bd48aac9107f14aaaa8e1139b/bundles/org.eclipse.e4.ui.workbench.swt/src/org/eclipse/e4/ui/internal/workbench/swt/E4Application.java#L388-L393

So it's effectively identical behavior but without an unfixable warning in the workspace.

@merks merks merged commit 4a125a4 into eclipse-packaging:master Jul 5, 2025
11 checks passed
@merks merks deleted the pr-LegacyIDE.e4xmi branch July 5, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant