Support creating the default c2e tenant w/o the demo device#415
Open
refi64 wants to merge 1 commit intoeclipse-packages:masterfrom
Open
Support creating the default c2e tenant w/o the demo device#415refi64 wants to merge 1 commit intoeclipse-packages:masterfrom
refi64 wants to merge 1 commit intoeclipse-packages:masterfrom
Conversation
This is useful for having a default tenant available for testing purposes without also having a demo device & credentials registered. Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
calohmn
reviewed
Sep 26, 2022
| tenant: "org.eclipse.packages.c2e" | ||
| demoDevice: | ||
| tenant: "org.eclipse.packages.c2e" | ||
| enabled: true |
Contributor
There was a problem hiding this comment.
Since there is also an enabled field in Hono device data, I think it would be better to choose a different property name here (e.g. create, or using skip or omit with inverted value).
calohmn
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for having a default tenant available for testing purposes without also having a demo device & credentials registered.
Signed-off-by: Ryan Gonzalez ryan.gonzalez@collabora.com