Merged
Conversation
1. Iox2Log.cs - Updated class-level documentation with details about v0.8.0 logging changes - Added list of available loggers (console, buffer, file, log, tracing) - Added build instructions for enabling file logger - UseConsoleLogger(): Marked as [Obsolete], now returns true (no-op since console is default) - UseFileLogger(): Marked as [Obsolete], throws NotSupportedException with instructions for alternatives 2. Iox2NativeMethods.cs - Removed P/Invoke declarations for iox2_use_console_logger() and iox2_use_file_logger() - Added comments explaining these were removed in v0.8.0 3. examples/Logging/Program.cs - Updated basic example to note console logger is now default - Removed call to UseConsoleLogger() (no longer needed) -Rewrote file logger example to use a custom logger callback that writes to file 4. examples/Logging/README.md - Added new section explaining v0.8.0 logging backend changes - Listed available loggers and their feature flags - Added build instructions for enabling native file logger - Updated API usage examples to reflect new behavior 5. examples/LoggingIntegration/README.md Added note about v0.8.0 changes and that SetLogger() continues to work
Contributor
|
Some documentation nitpicks from the examples:
|
dkroenke
reviewed
Jan 6, 2026
Contributor
dkroenke
left a comment
There was a problem hiding this comment.
Looks good and the Logging Example is functional. From my side this PR is ready to review so that we can run the CI.
This was referenced Jan 8, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5