Adding the Google Cloud Pub/Sub Emulator to allow local execution of …#3706
Adding the Google Cloud Pub/Sub Emulator to allow local execution of …#3706DominikBasnerSotec wants to merge 2 commits intoeclipse-hono:masterfrom
Conversation
…the Google Cloud PubSub related components
DominikBasnerSotec
requested review from
calohmn,
dejanb,
kaniyan and
sophokles73
as code owners
|
FYI: The reason there is an update here is that the device communication will soon also support this |
|
@sophokles73 @calohmn @kaniyan @dejanb any remarks yet? |
sophokles73
requested review from
mattkaem
and removed request for
calohmn,
dejanb and
kaniyan
sophokles73
left a comment
sophokles73
left a comment
There was a problem hiding this comment.
Thanks for the PR 👍
I am not sure if I fully understand the intent here, though.
I would have expected to find the emulator being used in the integration tests (e.g. using the emulator container image) instead of in the unit tests. The unit tests do not seem to benefit very much from using the emulator whereas I had always concerns because we could not run any integration tests for PubSub ...
| <url>https://www.eclipse.org/hono</url> | ||
|
|
||
| <properties> | ||
| <container.version>${project.version}</container.version> |
There was a problem hiding this comment.
what is the purpose of this change?
There was a problem hiding this comment.
Local testing against specific versions, so it can easily be exchanged
|
@sophokles73 You are right and we are planning to integrate it into the ITs, too. However, it is first needed for local execution and development and ITs will follow |
2 participants
…the Google Cloud PubSub related components