Skip to content

tenantAdapterStore should use tenantsProperties().getAdapter()#2321

Merged
kaniyan merged 2 commits intoeclipse-hono:masterfrom
lhotari:lh-fix-jdbc-tenant-adapter-store
Nov 23, 2020
Merged

tenantAdapterStore should use tenantsProperties().getAdapter()#2321
kaniyan merged 2 commits intoeclipse-hono:masterfrom
lhotari:lh-fix-jdbc-tenant-adapter-store

Conversation

@lhotari
Copy link
Contributor

@lhotari lhotari commented Nov 23, 2020

tenantAdapterStore should use tenantsProperties().getAdapter() instead of tenantsProperties().getManagement()
I noticed this small bug while working on #2317 .

Signed-off-by: Lari Hotari <lari@hotari.net>
@lhotari lhotari requested a review from dejanb as a code owner November 23, 2020 15:02
@kaniyan kaniyan added bug JDBC Device Registry The JDBC based Device Registry implementation labels Nov 23, 2020
@kaniyan kaniyan added this to the 1.5.0 milestone Nov 23, 2020
@kaniyan
Copy link
Contributor

kaniyan commented Nov 23, 2020

@lhotari Thank you for contributing :-)

Can you also please add yourself to the Copyright Holders section of the legal/src/main/resources/legal/NOTICE.md file?

@lhotari lhotari requested a review from sophokles73 as a code owner November 23, 2020 16:15
Signed-off-by: Lari Hotari <lari@hotari.net>
@lhotari lhotari force-pushed the lh-fix-jdbc-tenant-adapter-store branch from 089e69a to 9f00777 Compare November 23, 2020 16:15
@lhotari
Copy link
Contributor Author

lhotari commented Nov 23, 2020

@kaniyan thanks for reviewing.

Can you also please add yourself to the Copyright Holders section of the legal/src/main/resources/legal/NOTICE.md file?

done.

Copy link
Contributor

@kaniyan kaniyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaniyan kaniyan merged commit 11e3928 into eclipse-hono:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug JDBC Device Registry The JDBC based Device Registry implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants