Use auto-generated "disabled" icon when supported by SWT #786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The new warnings are technically correct and caused because deprecation warnings are currently ignored. See #778. I'll focus on getting the remaining warnings in GEF fixed, enable the setting there and then update this PR. |
ptziegler
force-pushed
the
issue732-pt2
branch
from
c7edc04 to
4e81164
Compare
SWT version 3.130.0 or newer is able to automatically generate a "disabled" icon. If such a version is used, it is no longer necessary to explicitly set it for e.g. an action. In short: If SWT < 3.130 is used, both "enabled" and "disabled" icons are set, otherwise only the "enabled" icon is set. Closes eclipse-gef#732
ptziegler
force-pushed
the
issue732-pt2
branch
from
4e81164 to
8f48c45
Compare
Contributor
Author
|
I've removed the suppression of the deprecation warnings, as they are not yet enabled for the GEF plugin. The only other warnings are produced by the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWT version 3.130.0 or newer is able to automatically generate a "disabled" icon. If such a version is used, it is no longer necessary to explicitly set it for e.g. an action.
In short: If SWT < 3.130 is used, both "enabled" and "disabled" icons are set, otherwise only the "enabled" icon is set.
Closes #732