Security Fix: adjust how the servlet context path is handled #5621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you! |
BalusC
pushed a commit
that referenced
this pull request
Jan 4, 2026
BalusC
added a commit
that referenced
this pull request
Jan 4, 2026
Contributor
Author
|
Hi @BalusC, thanks for merging our PR. We plan to request a CVE for this issue. Just wanna make sure if you are OK with us proceeding with the CVE submission. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a potential security vulnerability in
getRequestContextPathandgetApplicationContextPath.Details:
The implementation may be susceptible to a path traversal attack that results in an authentication bypass when used together with APIs or other web frameworks that route requests based on non-normalized requests.
Affected Function:
getRequestContextPathandgetApplicationContextPathFix of similar vulnerabilities: apache/shiro@b15ab92
What this PR does:
This PR applies the same security patch that was applied to the original repository to eliminate the potential vulnerability in
getRequestContextPathandgetApplicationContextPath.References:
apache/shiro@b15ab92
https://nvd.nist.gov/vuln/detail/cve-2023-34478
Please review and merge this PR to ensure your repository is protected against this potential vulnerability.