Add detection for legacy peak filter IDs in process methods #2124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mailaender
force-pushed
the
peak-filter-legacy-ids
branch
from
92608ea to
9e54293
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IDs for process methods use a hardcoded ID based on class name with inconsistent prefixes/suffixes to avoid collisions, which seems like a bad idea in the first place. In #1093 I accidentally changed the IDs of most peak filters with a simple namespace change. This adds a method to auto-detect and migrate those previous IDs, in the same vein as #1891 did for the settings content. It also allows us to clean them up with less volatile IDs in the future.