Remove most org.eclipse.tm.terminal.* features #1358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the TM Terminal migrated to Eclipse Terminal, remove the fine grained terminal features. The Eclipse Terminal feature will update from all of these features so users will have a continuous experience.
jonahgraham
added
releng
Member
Author
|
@laeubi / @ruspl-afed - your input is solicited here. I have a follow up PR that cleans up the remaining terminal/ folder too |
Member
Author
See #1360 for that part |
Contributor
|
Seems reasonable to me, but EPP would need adjustments as they are still using the old ones as far as I know |
Member
Author
|
Thanks for having a look, I did the epp update yesterday in eclipse-packaging/packages#370 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the TM Terminal migrated to Eclipse Terminal, remove the fine grained terminal features. The Eclipse Terminal feature will update from all of these features so users will have a continuous experience.
This requires Eclipse Platform change eclipse-platform/eclipse.platform#2199 which adds support for org.eclipse.tm.terminal features updating to org.eclipse.terminal feature. Please see that PR for details of how it behaves and testing done on this PR.