Skip to content

Add bogus release tag in file RELEASE#197

Merged
marcdumais-work merged 1 commit intomasterfrom
add-first-tag-release-file
Jan 31, 2024
Merged

Add bogus release tag in file RELEASE#197
marcdumais-work merged 1 commit intomasterfrom
add-first-tag-release-file

Conversation

@marcdumais-work
Copy link
Contributor

@marcdumais-work marcdumais-work commented Jan 31, 2024

That seems to be necessary for action "actions-gh-release" to work correctly for the first time.

Else we get the following error:

2024/01/30 22:49:25 Start running actions-gh-release 2024/01/30 22:49:25 Successfully parsed arguments
2024/01/30 22:49:25 Successfully parsed GitHub event pull_request
base-commit 939e8c2
head-commit 3e20521
2024/01/30 22:49:25 Failed to build release for RELEASE: tag must be specified

Note: the GitHub release job is still expected to fail in this PR - it should make it possible for #194 to succeed, once this here is merged and #194 is rebased.

That seems to be necessary for action "actions-gh-release" to
work correctly for the first time.

Else we get the following error:

2024/01/30 22:49:25 Start running actions-gh-release
2024/01/30 22:49:25 Successfully parsed arguments
2024/01/30 22:49:25 Successfully parsed GitHub event pull_request
	base-commit 939e8c2
	head-commit 3e20521
2024/01/30 22:49:25 Failed to build release for RELEASE: tag must be specified

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
Copy link
Contributor

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@marcdumais-work marcdumais-work merged commit e9b07c5 into master Jan 31, 2024
@marcdumais-work marcdumais-work deleted the add-first-tag-release-file branch January 31, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants