Skip to content

Conversation

@kuzniarz
Copy link

@kuzniarz kuzniarz commented Feb 8, 2024

Fixes several issues that were pointed out it in PR#988. This is the most actual branch there is and it contains all the implemented features by me

Context

kuzniarz and others added 22 commits May 15, 2020 14:59
…clipse-buildship#867)

* Implemented no-op UIs for workspace-composite wizard + preferences
* Changed workspace composite wizard element name
* Changed composite wizard element description
* Fixed java doc and useless indent
* Javadoc/author fix+ line nitpick
* Remove UiBuilder
* Fixed indend
* Fixed javadoc and indent
* Remove UiBuilder/JavaDoc fix
* Fixed checkbox tree layout
* Refactor HelpContextIdProvider and WizardHelper
* Knitpick and format fix

Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
Added most of the features to create a non functional workspace
composite, including:
- Definition of composite via wizard and working set GUI
- Adding projects to the composite via wizard and properties
- Changing composite properties via properties menu

Import of external projects has yet to be implemented

Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
Composite properties file creation was failing if properties directory
was not existent

Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
Commited by accident

Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
- Fixed all requested PR changes
- Started implementing new CompositeSelectionDialog


Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
- composite selection is not implemented yet

Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
- Changed GUI functionality and fixed several configuration bugs
- Added GUI-Strings to messages class

Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
…clipse-buildship#867)

* Implemented no-op UIs for workspace-composite wizard + preferences
* Changed workspace composite wizard element name
* Changed composite wizard element description
* Fixed java doc and useless indent
* Javadoc/author fix+ line nitpick
* Remove UiBuilder
* Fixed indend
* Fixed javadoc and indent
* Remove UiBuilder/JavaDoc fix
* Fixed checkbox tree layout
* Refactor HelpContextIdProvider and WizardHelper
* Knitpick and format fix

Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
Added most of the features to create a non functional workspace
composite, including:
- Definition of composite via wizard and working set GUI
- Adding projects to the composite via wizard and properties
- Changing composite properties via properties menu

Import of external projects has yet to be implemented

Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
Composite properties file creation was failing if properties directory
was not existent

Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
Commited by accident

Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
- Fixed all requested PR changes
- Started implementing new CompositeSelectionDialog

Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
- composite selection is not implemented yet

Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
- Changed GUI functionality and fixed several configuration bugs
- Added GUI-Strings to messages class

Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
Signed-off-by: Sebastian Kuzniarz <kuzniarz@zedat.fu-berlin.de>
Signed-off-by: Sebastian Kuzniarz <kuzniarz@zedat.fu-berlin.de>
@donat donat force-pushed the kuzniarz-workspace-composites-rebased branch from c9a60c1 to a582399 Compare April 19, 2024 14:30
@donat
Copy link
Contributor

donat commented Apr 19, 2024

Hi @kuzniarz
I've rebased https://github.com/eclipse/buildship/tree/workspace-composites and https://github.com/eclipse/buildship/tree/kuzniarz-workspace-composites-rebased such that they are based on the latest master and all changes are squashed to the latest commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants