Add aws-lc-rs crypto backend with trait-based abstraction#320
Open
preuss-adam wants to merge 4 commits intoeclipse-biscuit:mainfrom
Open
Add aws-lc-rs crypto backend with trait-based abstraction#320preuss-adam wants to merge 4 commits intoeclipse-biscuit:mainfrom
preuss-adam wants to merge 4 commits intoeclipse-biscuit:mainfrom
Conversation
- Add traits.rs with Backend, KeyPairImpl, PrivateKeyImpl, PublicKeyImpl - Add KeySerialization and KeyPemSerialization traits - Wire mod traits into crypto module
- Move ed25519.rs and p256.rs into default/ submodule - Implement KeyPairImpl, PrivateKeyImpl, PublicKeyImpl traits on default backend types - Rewrite mod.rs to use DefaultBackend + trait-based type aliases - Update scope.rs Display impl for new PublicKey type
- Implement Ed25519 and secp256r1 PublicKey, PrivateKey, KeyPair - Add AwsLcPublicKey trait with blanket KeyPemSerialization impl - Add P256 point compression/decompression via aws-lc-sys FFI - Add aws-lc-rs, aws-lc-sys deps; upgrade pkcs8 to 0.10.2 - Remove unused deps: sha2, prost-types, getrandom, ecdsa, elliptic-curve - Add tests for sign/verify, serialization, PEM/DER roundtrips
- Make ed25519-dalek, p256, aws-lc-rs, aws-lc-sys optional deps - Add default-backend and awslc-backend feature flags - Add default-backend-pem synthetic feature for dalek pem/pkcs8 - Make pem feature standalone - Gate awslc module with not(default-backend) to prevent conflicting impls - default-backend takes priority when both features are enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
default/backend implementing the new traitsdefault-backend(ed25519-dalek/p256) andawslc-backend(aws-lc-rs)Benchmarks
Ed25519 verification (third-party checks)
P256 verification (third-party checks)
Usage
Default (ed25519-dalek + p256):
aws-lc-rs backend: