Make wasm-bindgen optional for wasm32 target#316
Open
Wonshtrum wants to merge 1 commit intoeclipse-biscuit:mainfrom
Open
Make wasm-bindgen optional for wasm32 target#316Wonshtrum wants to merge 1 commit intoeclipse-biscuit:mainfrom
Wonshtrum wants to merge 1 commit intoeclipse-biscuit:mainfrom
Conversation
Signed-off-by: Eloi DEMOLIS <eloi.demolis@clever-cloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to embed
biscuit-authcompiled to wasm32 is a pain outside of JavaScript due to wasmbindgen.It generates a lot of boilerplate, which is tedious and error-prone to mock correctly.
In this PR I propose to make the old
wasmfeature optional for the wasm32-unknown-unknown target and rename itwasm-bindgento avoid confusion.The only necessary import is for time, which is implemented through
performance_nowwith wasmbindgen. I propose, for a pure wasm32 target, to create a simpleinstant_nowsymbol returning a u64, meant to represent a monotonic timestamp, and let the user provide the right implementation in their environment.note: we could keep the name
wasmfor the feature making it a non breaking change, but I find it pretty confusing.