WIP: remove ToAnyParam and use Into<Param> instead#314
Draft
WIP: remove ToAnyParam and use Into<Param> instead#314
ToAnyParam and use Into<Param> instead#314Conversation
divarvel
force-pushed
the
push-tyuolupwolsq
branch
2 times, most recently
from
bfe8fa6 to
d23e011
Compare
6 tasks
divarvel
force-pushed
the
push-tyuolupwolsq
branch
from
d23e011 to
a018fb3
Compare
Geal
approved these changes
Sep 16, 2025
macros resolve scope parameters and regular parameters through the `ToAnyParams` trait, losing the ability to discriminate between the two in a static way. This leads to panics instead of compilation errors.
This removes the possibility to provide a public key where a term is expected and leverages a standard trait instead of a custom one
divarvel
force-pushed
the
push-tyuolupwolsq
branch
from
a018fb3 to
b99af0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #302
The goal is to:
ToAnyParamin favor ofInto<AnyParam>for simplicityThe main difference is that
ToAnyParamtakes a reference, whileIntoconsumes its input.todo
Into<Term>instead ofT: ToAnyParamInto<(PublicKey, Vec<PublicKey>)>instead ofPublicKey