Split out core logic from library dependencies#139
Open
preuss-adam wants to merge 9 commits intoeclipse-biscuit:mainfrom
Open
Split out core logic from library dependencies#139preuss-adam wants to merge 9 commits intoeclipse-biscuit:mainfrom
preuss-adam wants to merge 9 commits intoeclipse-biscuit:mainfrom
Conversation
This requires an update to error handling for invalid key size.
This prepares for the eventual split into biscuit and biscuit-core.
Additionally, we remove support for nondeterministic nonce. Users that desire this can implement their own KeyPairFactory.
- Use `ServiceProvider` to pull in default implementations. - Add exports for the default factories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is best reviewed commit by commit. At a high level, the goal is to split out the core biscuit logic from its crypto and regex dependencies so that users of the library can use their own implementations of these.
The library is split into two modules:
biscuitandbiscuit-core. Existing users of the library can continue to use the library as normal by simply depending onbiscuit. Users wishing to implement/inject their own dependencies can do so using java'sServiceLoader.Incidentally, with this change, we assume ECDSA is now always deterministic, as described in #135. A user can choose different behaviour now by adding their own crypto provider.