Closed
Conversation
Contributor
|
there’s a small formatting error it seems. could you run cargo fmt and update the pr please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates from Clap 3.2 to Clap 4.5, updating all deprecated APIs and syntax to follow Clap 4.x conventions.
Core Updates
Attribute syntax changes:
value_name("FOO")→value_name = "FOO"conflicts_with("foo-bar")→conflicts_with("foo_bar")(underscore naming)requires("foo-bar")→requires("foo_bar")Custom parsers:
parse(try_from_str = func)→value_parser = clap::builder::ValueParser::new(func)parse_ttl,parse_duration,parse_rule, andparse_paramPath handling:
parse(from_os_str)forPathBufarguments (auto-detected in Clap 4)Type System Updates
Import changes:
clap::PossibleValue→clap::builder::PossibleValueTrait implementation:
ValueEnum::to_possible_value()signature simplified (removed explicit lifetime)Type derivations:
ClonetoTtlenum forvalue_parsercompatibilityI've tested this against tests from #76 and a bash script generating outputs of multiple commands to look for any differences. I didn't notice any, except those linked to different Clap 4.x helpers style.