Skip to content
This repository was archived by the owner on Mar 5, 2021. It is now read-only.

Conversation

@chiboycalix
Copy link

  • this is important so that first timers get to know what OSGi means from the Readme.MD file

- [x] this is important so that first timers get to know what OSGi means from the Readme.MD file
@Oyinna
Copy link

Oyinna commented Jan 12, 2021

thoughtful!

Copy link
Contributor

@ctron ctron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR … even though it is only a small PR, you would still need to sign off the commit with an e-mail address that has accepted the ECA: https://www.eclipse.org/legal/ECA.php

Co-authored-by: Jens Reimann <ctron@dentrassi.de>
@chiboycalix
Copy link
Author

@ctron I have made the changes requested

@ctron
Copy link
Contributor

ctron commented Jan 20, 2021

Thanks for following up.

Unfortunately I still cannot see the required Signed-off-by trailer in the two git commits. They are mandatory however: https://www.eclipse.org/projects/handbook/#resources-commit

@chiboycalix
Copy link
Author

Thanks for following up.

Unfortunately I still cannot see the required Signed-off-by trailer in the two git commits. They are mandatory however: https://www.eclipse.org/projects/handbook/#resources-commit

  • Hi @ctron I have included the "signed-off-by" footer in the commit message. Thanks

@ctron
Copy link
Contributor

ctron commented Jan 25, 2021

I can still see two commits without the header. All commits need to be signed. You can achieve this by "squashing commits": https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History#_squashing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants