Skip to content

Conversation

@hanpeic
Copy link

@hanpeic hanpeic commented May 26, 2017

updated jar file version
improve QR code decode ability same as the website: zxing.org

@ecin
Copy link
Owner

ecin commented May 26, 2017

Thanks for your PR! Will review shortly. 😄

@ecin
Copy link
Owner

ecin commented May 26, 2017

@hanpeic can you add a description that explains how this code works, and why it's needed?

By the way, thanks for adding so many fixtures to the code!

@hanpeic
Copy link
Author

hanpeic commented May 26, 2017

Hi @ecin thanks for your quick reply. When I call this gem to parse QR code, I find some QR code parse failed, but if I upload to zxing.org, it could get the result. After I checked the source code of zxing.org, the key point is this line:
https://github.com/zxing/zxing/blob/master/zxingorg/src/main/java/com/google/zxing/web/DecodeServlet.java#L367

It tries 'HybridBinarizer' to parse again if first time failed. so I add same code in this gem. to make sure if a QR code could parse by zxing.org, then It could parse by this gem too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants