Skip to content
This repository was archived by the owner on Feb 9, 2024. It is now read-only.

Update dependency eslint-plugin-simple-import-sort to v10#183

Closed
renovate[bot] wants to merge 1 commit intomainfrom
renovate/eslint-plugin-simple-import-sort-10.x
Closed

Update dependency eslint-plugin-simple-import-sort to v10#183
renovate[bot] wants to merge 1 commit intomainfrom
renovate/eslint-plugin-simple-import-sort-10.x

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Jan 30, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint-plugin-simple-import-sort 7.0.0 -> 10.0.0 age adoption passing confidence

Release Notes

lydell/eslint-plugin-simple-import-sort

v10.0.0

Compare Source

This release might move some imported items with type around. This is a breaking formatting change (that only affects TypeScript and Flow), but only in the form of that you need to autofix your files.

In previous versions, type specifiers came first:

import { type B, a } from "a";
export { type B, a } from "a";

Now, all specifiers are sorted alphabetically, regardless of type:

import { a, type B } from "a";
export { a, type B } from "a";

Motivation:

You might import a class for a type annotation using:

import {
  type MyClass,
  coolFunction,
} from "example";

Later, you also start instantiating that class in the same file (new MyClass()), so you remove type.

Previously, this resulted in a messy diff due to the class moving:

 import {
-  type MyClass,
   coolFunction,
+  MyClass,
 } from "example";

Now, the sorting with the type keyword would be:

import {
  coolFunction,
  type MyClass,
} from "example";

Now there’s no reordering diff, just the type keyword being removed:

 import {
   coolFunction,
-   type MyClass,
+   MyClass,
 } from "example";

This is consistent with [“Why sort on from?”][sort-from].

Thanks to Jake Bailey (@​jakebailey) for reporting and suggesting the fix!

v9.0.0

Compare Source

This version adds support for [eslint-plugin-svelte], and for declare module in TypeScript.

More generally, imports and exports are now supported anywhere, by finding the set of parents of all imports and exports and working with those. Previously, the plugin only sorted imports and exports directly inside a Program node. For eslint-plugin-svelte and declare module that didn’t cut it.

This is only a breaking change if you imports or exports in declare module in TypeScript, and only in the form of that you need to autofix your files.

v8.0.0

Compare Source

Node.js builtin modules prefixed with node: are now in a separate group by default (regex: ^node:), above the packages group. (Node.js builtins without node: are still sorted together with npm packages like before.)

Before:

import fs from "fs";
import _ from "lodash-es";
import { rmSync } from "node:fs";

After:

import { rmSync } from "node:fs";

import fs from "fs";
import _ from "lodash-es";

This is only a breaking change if you use the node: prefix in imports, and only in the form of that you need to autofix your files.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@vercel
Copy link

vercel bot commented Jan 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
website ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 30, 2023 at 10:17PM (UTC)

@renovate renovate bot added the renovate label Jan 30, 2023
@renovate
Copy link
Contributor Author

renovate bot commented Jan 30, 2023

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @tailwindcss/forms@0.5.3
npm ERR! Found: tailwindcss@2.2.19
npm ERR! node_modules/tailwindcss
npm ERR!   dev tailwindcss@"2.2.19" from the root project
npm ERR!   peer tailwindcss@">=2.0.0 || >=3.0.0 || >=3.0.0-alpha.1" from @tailwindcss/aspect-ratio@0.4.2
npm ERR!   node_modules/@tailwindcss/aspect-ratio
npm ERR!     @tailwindcss/aspect-ratio@"0.4.2" from the root project
npm ERR!   2 more (@tailwindcss/line-clamp, @tailwindcss/typography)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer tailwindcss@">=3.0.0 || >= 3.0.0-alpha.1" from @tailwindcss/forms@0.5.3
npm ERR! node_modules/@tailwindcss/forms
npm ERR!   dev @tailwindcss/forms@"0.5.3" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: tailwindcss@3.2.4
npm ERR! node_modules/tailwindcss
npm ERR!   peer tailwindcss@">=3.0.0 || >= 3.0.0-alpha.1" from @tailwindcss/forms@0.5.3
npm ERR!   node_modules/@tailwindcss/forms
npm ERR!     dev @tailwindcss/forms@"0.5.3" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /tmp/renovate-cache/others/npm/_logs/2023-01-30T22_15_26_503Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in:
npm ERR!     /tmp/renovate-cache/others/npm/_logs/2023-01-30T22_15_26_503Z-debug-0.log

@renovate
Copy link
Contributor Author

renovate bot commented Feb 10, 2023

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 10.x releases. But if you manually upgrade to 10.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/eslint-plugin-simple-import-sort-10.x branch February 10, 2023 18:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant