Skip to content

Conversation

@linuxrider
Copy link
Contributor

@linuxrider linuxrider commented Aug 25, 2025

Comment on lines 42 to 44
"Uncertainty": {
"anyOf": [
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add a unit field. The "number" field should probably be "value", as is the case for "quantity"?

@DunklesArchipel
Copy link
Member

To test this, we should add some tests to any of the YAML files in the example section.
https://github.com/echemdb/metadata-schema/blob/main/examples/objects/system.yaml
and maybe the output JSON
https://github.com/echemdb/metadata-schema/blob/main/examples/file_schemas/echemdb_package.json

@DunklesArchipel DunklesArchipel mentioned this pull request Aug 26, 2025
@DunklesArchipel
Copy link
Member

Running local tests with pixi run validate results in the following error

Pixi task (validate-objects): bash -c "    find . -type f -name \"*.json\" -exec sed -i '/$id/d' {} +
    for file in curation eln experimental figure_description projects source system; do
        check-jsonschema --schemafile ./schemas/${file}.json ./examples/objects/${file}.yaml
    done
    "                                                                                                                                                                                                                          
sed: -e expression #1, char 0: no previous regular expression                                                                                                                                                                  
ok -- validation done
ok -- validation done
ok -- validation done
ok -- validation done
ok -- validation done
ok -- validation done
Schema validation errors were encountered.
  ./examples/objects/system.yaml::$.electrolyte.temperature: Additional properties are not allowed ('uncertainty' was unexpected)

I am not exactly sure how the referencing works and, hence, locally the data is tested against the web version of the older metadata schema.

@DunklesArchipel
Copy link
Member

I changed pH into a quantity

@DunklesArchipel DunklesArchipel merged commit 982a6f2 into echemdb:main Aug 27, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uncertainity

2 participants