-
Notifications
You must be signed in to change notification settings - Fork 2
add uncertainty and comment to quantity #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
schemas/general/quantity.json
Outdated
| "Uncertainty": { | ||
| "anyOf": [ | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also add a unit field. The "number" field should probably be "value", as is the case for "quantity"?
|
To test this, we should add some tests to any of the YAML files in the example section. |
|
Running local tests with Pixi task (validate-objects): bash -c " find . -type f -name \"*.json\" -exec sed -i '/$id/d' {} +
for file in curation eln experimental figure_description projects source system; do
check-jsonschema --schemafile ./schemas/${file}.json ./examples/objects/${file}.yaml
done
"
sed: -e expression #1, char 0: no previous regular expression
ok -- validation done
ok -- validation done
ok -- validation done
ok -- validation done
ok -- validation done
ok -- validation done
Schema validation errors were encountered.
./examples/objects/system.yaml::$.electrolyte.temperature: Additional properties are not allowed ('uncertainty' was unexpected)I am not exactly sure how the referencing works and, hence, locally the data is tested against the web version of the older metadata schema. |
|
I changed pH into a quantity |
needed for echemdb/electrochemistry-data#89
Fixes #80