Makefile error #45
Open
Makefile error #45
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saraedum
reviewed
Jan 2, 2025
| # We create a data package, i.e., a .csv and a .json file, from a .yaml and a | ||
| # .svg files by invoking the svgdigitizer. | ||
| ${TARGET_DIR}/%.csv ${TARGET_DIR}/%.json : ${SOURCE_DIR}/%.yaml ${SOURCE_DIR}/%.svg | ||
| ${SVGDIGITIZER} cv --sampling-interval ${SAMPLING_INTERVAL} --si-units --bibliography --metadata $< ${patsubst %.yaml,%.svg,$<} --outdir=${@D} 2>&1 | awk '{ print "'$<': "$$0 }' |
Member
There was a problem hiding this comment.
Why do you not want to see stderr anymore here?
Member
Author
There was a problem hiding this comment.
Somehow, the test for building packages does not fail when the SVG is empty, as it is the case in the demo files below. At least now we can see in the tests (Checks) a Python error. Ideally, we we should add a test that first checks newly added files, then all tests can be evoked. This PR is merely a test. This can also be discussed in #45 .
Member
There was a problem hiding this comment.
I have no idea what you are saying here, sorry ;)
Maybe we can discuss that in our call.
saraedum
reviewed
Jan 16, 2025
Comment on lines
1
to
5
| <?xml version="1.0" encoding="utf-8" ?> | ||
| <svg xmlns="http://www.w3.org/2000/svg" xmlns:ev="http://www.w3.org/2001/xml-events" xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape" xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd" xmlns:xlink="http://www.w3.org/1999/xlink" baseProfile="full" height="6497px" version="1.1" width="4961px"> | ||
| <defs/> | ||
| <image height="6497px" sodipodi:insensitive="true" width="4961px" x="0" xlink:href="meng_2012_the_5222_p3.png" y="0"/> | ||
| </svg> |
Member
There was a problem hiding this comment.
Shouldn't there be something in here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Literature Addition Checklist
For contributors and reviewers alike.
Add literature_identifierFilename
<Name>_<Year>_<FirstWordFirstPage>_<FirstPageNumber>_<fxy>_<Identifier>, where x is the figure number and y the subfigure label, i.e., 2b. For supporting information figures, usesfxyinstead.Bib file
Pt (111)toPt(111).SVG
Figure: xy(notFigure: fxy).tagstext label should be included in the SVG indicating the type of measurement (BCV, ORR, COOR, etc).YAML