Skip to content

Develop #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jayvarner merged 2 commits into from
Oct 20, 2025
Merged

Develop #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b5d443
Include previously published label
jayvarner Oct 20, 2025
7f07fc2
Move previously published out of metadata
jayvarner Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/views/letters/_letter.json.jbuilder
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ json.repositories do
end
end

json.set! 'previously_published', letter.letter_publisher.label if letter.letter_publisher.present?

json.set! 'publication_information', letter.publication_information if letter.publication_information.present?

json.recipients do
Expand Down
1 change: 1 addition & 0 deletions spec/requests/letters_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@
expect(letter.published).to be(true)
get letter_url(letter), as: :json
expect(json[:repositories]).to be_nil
expect(json[:previously_published]).to eq(letter.letter_publisher.label)
end

it 'renders unpublished when requested from beckettapi' do
Expand Down