📝 Add comments #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds authentication, CSRF protection, and comprehensive security features to the sleep API. The changes include login/logout functionality, encrypted session cookies, double-submit CSRF protection, security headers, and authentication middleware.
Key changes:
- Implements single-user authentication with session cookies and CSRF protection
- Adds security middleware and headers for production deployment
- Updates all existing endpoints to require authentication and CSRF protection for mutating operations
Reviewed Changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sleep-api/src/auth.rs | Core authentication utilities for session management and credential verification |
| sleep-api/src/security/ | CSRF protection and security headers implementation |
| sleep-api/src/middleware/ | Authentication extractors for protecting routes |
| sleep-api/src/app.rs | Updated router with login/logout endpoints and auth requirements |
| sleep-api/tests/ | Test files updated with authentication and CSRF handling |
| sleep-api/src/config.rs | Configuration helpers for admin credentials and cookie settings |
| Cargo.toml | Added dependencies for authentication and testing |
| openapi.yaml | Updated API specification with authentication requirements |
| README.md | Comprehensive documentation for authentication and security features |
| .env.example | Environment configuration template |
…login and /logout; protect /trends and mutating APIs; add tests (auth_csrf) and update existing tests; switch CSRF token to URL-safe base64; clippy clean
…ppState, config, and pw-hash; align with existing project style
…satisfy type inference; all tests pass
…y warnings in tests (format args, remove needless borrows); keep unsafe env var blocks per project guidance. Refs #5
…itch RNG sources to password-hash rand_core OsRng to resolve rand_core version mismatch; run cargo fmt and clippy; address PR feedback. Refs #5
…pendency; run fmt/clippy. Refs #5
…use config-based names for session/CSRF cookies; switch to axum_extra::either::Either for /login form+JSON
… CSRF; update README for COOKIE_SECURE and double-submit
…t(session): add SESSION_TTL_HOURS Max-Age; feat(security): COOKIE_SECURE dev-mode cookie names/flags; refactor(csrf): dynamic cookie names and header handling; docs(openapi,README): add /login.json, securitySchemes and CSRF requirements; chore(CSP): add connect-src 'self'
…-protect /logout; gate GET /sleep/date and trends APIs by session. headers: CSP allow cdn.jsdelivr.net for Chart.js.
… protected endpoints; gate GET endpoints in spec. tests: CSRF required on logout; add percent-encoded CSRF header test and dev cookie flags test.
…tests; add percent-encoded token and dev cookie flags coverage. build: add serial_test dev-dep.
ebigunso
force-pushed
the
feature/2025-08-11/security-update
branch
from
055d64c to
26e9865
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.