[pull] master from ppy:master #4
Open
+339,716
−96,399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dling Adjust alpha handling for values exceeding 1 for storyboard sprite transforms to match stable behavior.
Fix cursor trail detaching from cursor when adjusting cursor scale
…ng-in-editor Fix storyboard samples not playing in editor
…te (#35957) * Add failing test for copy->paste not being idempotent * Ensure all elements on default skins use fixed anchors `UsesFixedAnchor` defaults to false, i.e. closest anchors. Combined with manual anchor / origin specs on some drawables, this would get default skins into impossible states wherein a drawable would use "closest anchor" but also explicitly specify anchor / origin that aren't closest, which horribly fails on attempting to copy and paste. Frankly shocked this has gone unnoticed for this long, and I regret not vetoing this "feature" more every time I see its tentacles spread to produce breakage of levels yet unseen. Does this commit contain major levels of suck? For sure. Do I have any better ideas that wouldn't consist of a multi-day rewrite or deletion of this "feature"? No. * Fix skin editor always applying closest anchor / origin on paste regardless of whether the component uses fixed anchor Self-explanatory. Should close #29111 along with previous commit.
"Closes" #35920. The button can't easily work anyway since it's not guaranteed that the spectating user has all of the frames of the replay (think entering spectate midway through a play). This matches the results screen in spectator too.
…is released outside of overlay content (#35940) * Add failing test * Fix dragging volume meter to adjust volume closing overlays if mouse is released outside of overlay content Fixes https://osu.ppy.sh/community/forums/topics/2159553.
Make tracked leaderboard score yellow again
This fixes the editor no longer seeking smoothly when paused. Closes #35963.
Fix editor not seeking smoothly when paused
… flashing during local score retrieval Closes #35893.
…ad-network Fix audio track potentially muting after gameplay with bad network
Slightly delay song select leaderboard's loading placeholder to avoid flashing during local score retrieval
Forcefully leave room on multiplayer exit
Various minor quick play UX fixes
Update localisation analyser packages
Add "legacy" pp counter
Require hold-to-exit during multiplayer load
Fix replay settings overlay appearing momentarily during gameplay retry
This is the counterpart to ppy/osu-server-spectator#413. The goal is to log the value which is seemingly failing to work correctly client-side as well. The reason for doing that is two-fold: - To eliminate possibility of freakazoid issues wherein some computers miscalculate the version hash somehow - To eliminate possibility of the version hash somehow getting lost in transit (e.g. present client-side but no longer present server-side).
Log version hash to sentry
See ppy/osu-web#12651 for web-side implementation. To be used to fix https://github.com/ppy/osu/pull/33649/changes#diff-32784a778b34c671e1f72c00e1f4161a5e774e849aae5631ee71b31fc32e5d42R218 (have tested this works there). Use simple set-get rather than transforming to `APIUser.Statistics`
Fix now playing overlay buttons not showing toggle colour correctly
…fety Add safeties against exceptions in `OnlineLookupCache`
Add support for global rank parsing in /users/ batch lookups
Support text wrapping in form controls
Implements ppy/osu-web#12363 There's one less colour in the spectrum than in the [web code](https://github.com/ppy/osu-web/pull/12363/changes#diff-a9bdefd7233ca98f7f89cd76213aba5d869ae0424c8e79d1e322abd3e43462fbR31) because the spectrum was actually defined incorrectly and has [one less domain entry than it should](https://github.com/ppy/osu-web/pull/12363/changes#diff-a9bdefd7233ca98f7f89cd76213aba5d869ae0424c8e79d1e322abd3e43462fbR29). I've chose to not add it because of consistency with the web and because it looked pretty ugly (it was pretty much unreadable) <img width="1361" height="814" alt="image" src="https://github.com/user-attachments/assets/5f9d7a93-3e28-4b8c-952c-0abd6f8c2cc3" /> <img width="805" height="647" alt="image" src="https://github.com/user-attachments/assets/b060cba7-3beb-4bb5-8d50-6210e8417715" />
Fix broken date formatting in some languages on several overlays
Fixes https://osu.ppy.sh/community/forums/topics/2169899?n=1. `TimePreempt` doesn't affect the appearance of a spinner, but it *will* affect the value of `GameplayStartTime`: https://github.com/ppy/osu/blob/4bf90a5571bb508444178f3d98a2b2a10c549534/osu.Game.Rulesets.Osu/UI/DrawableOsuRuleset.cs#L82-L91 While at parsing it is enforced that every object following a spinner has `NewCombo` set, it is *not* enforced that every spinner has `NewCombo` set. See also: #24156. But that's sort of orthogonal to the entire issue as well because why touch the preempt of an object that's not visually affected by preempt to begin with.
Fix Freeze Frame mod suppressing skip if the first object is a spinner
…anging language (#36303) Fixes #36274 **Change:** Registered a `BindValueChanged` callback on each TabItem’s `Text.Current` to ensure the underline indicator (strip) updates whenever the displayed tab text changes and calling `updateDisplay` accordingly to update the underline. **Result:** https://github.com/user-attachments/assets/6fb95a46-c768-46ec-a68a-a5e394e08a78 --------- Signed-off-by: Linus Genz <linuslinuxgenz@gmail.com> Co-authored-by: Dean Herbert <pe@ppy.sh>
~i recently saw an suggestion to do this, but don't remember where~ - addresses #36189 i think it's logical, since the settings have been displayed in a separate overlay for more than six months, and not on top of the gameplay itself, and for example, it can be difficult to expand section on phones | master | pr | |-|-| | <img width="1920" height="1080" alt="osu_2026-01-12_09-40-23" src="https://github.com/user-attachments/assets/35d15ce6-ce12-4a9a-be4e-d72043dfb91a" /> | <img width="1920" height="1080" alt="osu_2026-01-12_09-39-40" src="https://github.com/user-attachments/assets/225d75db-1719-48dc-a65f-16272cca8295" /> |
…und-reveal Hide cursor during background reveal in song select
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )