Open
Conversation
…entations, enhance accessibility features, and include comprehensive documentation.
There was a problem hiding this comment.
Pull Request Overview
This PR implements a comprehensive Tabs component that replaces the previous horizontal-only tabs implementation. The component now supports both horizontal and vertical orientations with enhanced accessibility features including ARIA compliance, keyboard navigation, and comprehensive documentation.
Key Changes:
- Replaced the old
horizontal-tabscomponent with a unifiedtabscomponent supporting both horizontal and vertical orientations - Enhanced accessibility with proper ARIA roles, keyboard navigation (arrow keys, Home/End), and roving tabindex
- Added extensive documentation covering usage, CSS variables, accessibility guidelines, and browser requirements
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/edw_paragraphs_tabs/templates/paragraph--edw-tabs.html.twig | Updated to use new tabs component with vertical direction parameter |
| modules/edw_paragraphs_tabs/templates/paragraph--edw-tab--default.html.twig | Simplified template by removing wrapper elements |
| modules/edw_paragraphs_tabs/components/tabs/tabs.twig | New unified tabs component template with support for both orientations |
| modules/edw_paragraphs_tabs/components/tabs/tabs.md | Comprehensive documentation for the tabs component |
| modules/edw_paragraphs_tabs/components/tabs/tabs.js | JavaScript implementation with keyboard navigation and orientation support |
| modules/edw_paragraphs_tabs/components/tabs/tabs.css | Styling for both horizontal and vertical tab orientations |
| modules/edw_paragraphs_tabs/components/tabs/tabs.component.yml | Component configuration and property definitions |
| modules/edw_paragraphs_tabs/components/horizontal-tabs/horizontal-tabs.twig | Removed old horizontal-only tabs template |
| modules/edw_paragraphs_tabs/components/horizontal-tabs/horizontal-tabs.js | Removed old horizontal-only tabs JavaScript |
| modules/edw_paragraphs_tabs/components/horizontal-tabs/horizontal-tabs.css | Removed old horizontal-only tabs styles |
| modules/edw_paragraphs_tabs/components/horizontal-tabs/horizontal-tabs.component.yml | Removed old horizontal-only tabs configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
modules/edw_paragraphs_tabs/templates/paragraph--edw-tab--default.html.twig
Outdated
Show resolved
Hide resolved
…e JS functionality, and remove unused files
…classes, and improve accessibility attributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add support for horizontal and vertical orientations, enhance accessibility features, and include comprehensive documentation.